fix: fix advisories cards breakpoints and spacing - #1724
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1724 +/- ##
=======================================
Coverage 77.49% 77.49%
=======================================
Files 102 102
Lines 3301 3302 +1
Branches 759 758 -1
=======================================
+ Hits 2558 2559 +1
Misses 664 664
Partials 79 79 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hi @MariSvirik, we talked abut the card item spacing. I increased the line height to 2 and think it looks much better. I'd love to know what you think! |
Dugowitch
force-pushed
the
advisories-cards
branch
from
July 30, 2026 13:59
591ba08 to
d2503b6
Compare
Dugowitch
enabled auto-merge (squash)
July 30, 2026 14:17
Dugowitch
disabled auto-merge
July 30, 2026 14:17
Dugowitch
force-pushed
the
advisories-cards
branch
3 times, most recently
from
August 4, 2026 09:10
395c277 to
d2f92aa
Compare
Contributor
Author
|
Rebased and updated the card item vertical spacing based on Maria's feedback, can merge now |
Dugowitch
enabled auto-merge (squash)
August 4, 2026 09:11
Dugowitch
force-pushed
the
advisories-cards
branch
from
August 4, 2026 10:52
d2f92aa to
78a5c2f
Compare
Dugowitch
disabled auto-merge
August 4, 2026 10:57
TenSt
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Associated Jira ticket: HMS-10843
Fix advisories cards brakpoints to prevent the left and right side from touching.
Increase line height in the card so that the item are not so squashed.
How to test the PR
Before the change
After the change
Checklist: